Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: check grpc peer info for download service #2385

Merged
merged 5 commits into from May 25, 2023
Merged

chore: check grpc peer info for download service #2385

merged 5 commits into from May 25, 2023

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented May 25, 2023

Description

Only allow download call from unix domain socket.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@jim3ma
chore: check authority for download service
b542571 
Signed-off-by: Jim Ma <majinjing3@gmail.com>
@jim3ma jim3ma requested a review from a team as a code owner May 25, 2023 06:10
@jim3ma
chore: update comment
45ef8fb 
Signed-off-by: Jim Ma <majinjing3@gmail.com>
@jim3ma
chore: update check logic
30dacb4 
Signed-off-by: Jim Ma <majinjing3@gmail.com>
gaius-qi
gaius-qi previously approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bigerous
bigerous previously approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@bigerous bigerous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim3ma
fix: unit test
fabf04c 
Signed-off-by: Jim Ma <majinjing3@gmail.com>
@jim3ma jim3ma dismissed stale reviews from bigerous and gaius-qi via fabf04c May 25, 2023 07:23
@codecov
Copy link

codecov bot commented May 25, 2023 •
edited

Codecov Report

Merging #2385 (866ae89) into main (1a11fc2) will increase coverage by 0.01%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2385      +/-   ##
==========================================
+ Coverage   49.35%   49.36%   +0.01%     
==========================================
  Files         146      146              
  Lines       19672    19682      +10     
==========================================
+ Hits         9709     9717       +8     
  Misses       9354     9354              
- Partials      609      611       +2
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 49.36% <20.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/rpcserver/rpcserver.go 48.40% <20.00%> (-0.37%) ⬇️

... and 3 files with indirect coverage changes

@jim3ma
chore: check grpc peer instead of metadata
866ae89 
Signed-off-by: Jim Ma <majinjing3@gmail.com>
@jim3ma jim3ma changed the title chore: check authority for download service chore: check grpc peer info for download service May 25, 2023
gaius-qi
gaius-qi approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bigerous
bigerous approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@bigerous bigerous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim3ma jim3ma merged commit e4deba0 into main May 25, 2023
21 checks passed
@jim3ma jim3ma deleted the chore/check-authority branch May 25, 2023 09:28
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
@jim3ma @gaius-qi
chore: check grpc peer info for download service (#2385)
afb47f6 
Signed-off-by: Jim Ma <majinjing3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaius-qi gaius-qi gaius-qi approved these changes

@bigerous bigerous bigerous approved these changes

@liubin liubin Awaiting requested review from liubin liubin is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@KubeStacker KubeStacker Awaiting requested review from KubeStacker KubeStacker is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jim3ma @gaius-qi @bigerous