Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add scan function in redis and neighbours function in network topology #3048

Merged
merged 22 commits into from Feb 2, 2024

Conversation

fcgxz2003
Copy link
Member

@fcgxz2003 fcgxz2003 commented Jan 24, 2024

Add scan function in cache to get a specified number of matching regexp key.
Add neighbours function to get the specified number of neighbors for source host.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: fcgxz2003 <834756128@qq.com>
Signed-off-by: fcgxz2003 <834756128@qq.com>
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (8fa57ca) 51.55% compared to head (5ad8805) 51.64%.
Report is 1 commits behind head on main.

❗ Current head 5ad8805 differs from pull request most recent head 1d7a517. Consider uploading reports for the commit 1d7a517 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3048      +/-   ##
==========================================
+ Coverage   51.55%   51.64%   +0.08%     
==========================================
  Files         163      163              
  Lines       22246    22302      +56     
==========================================
+ Hits        11470    11518      +48     
- Misses      10114    10123       +9     
+ Partials      662      661       -1     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 51.64% <88.70%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/cache/cache.go 83.85% <100.00%> (+1.08%) ⬆️
scheduler/networktopology/network_topology.go 100.00% <100.00%> (ø)
pkg/cache/cache_mock.go 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

fcgxz2003 and others added 7 commits January 25, 2024 22:22
Signed-off-by: fcgxz2003 <834756128@qq.com>
Signed-off-by: fcgxz2003 <834756128@qq.com>
Signed-off-by: fcgxz2003 <834756128@qq.com>
Signed-off-by: fcgxz2003 <834756128@qq.com>
Signed-off-by: fcgxz2003 <834756128@qq.com>
Signed-off-by: fcgxz2003 <834756128@qq.com>
pkg/cache/cache.go Outdated Show resolved Hide resolved
Signed-off-by: fcgxz2003 <834756128@qq.com>
Signed-off-by: fcgxz2003 <834756128@qq.com>
Signed-off-by: fcgxz2003 <834756128@qq.com>
pkg/cache/cache.go Show resolved Hide resolved
scheduler/networktopology/network_topology.go Outdated Show resolved Hide resolved
scheduler/networktopology/network_topology.go Outdated Show resolved Hide resolved
Signed-off-by: fcgxz2003 <834756128@qq.com>
Signed-off-by: fcgxz2003 <834756128@qq.com>
@fcgxz2003 fcgxz2003 changed the title feat: add neighbours function feat: add scan function in redis and neighbours function in network topology Feb 1, 2024
Signed-off-by: fcgxz2003 <834756128@qq.com>
Signed-off-by: fcgxz2003 <834756128@qq.com>
Signed-off-by: XZ <834756128@qq.com>
Signed-off-by: XZ <834756128@qq.com>
Signed-off-by: XZ <834756128@qq.com>
Signed-off-by: XZ <834756128@qq.com>
Signed-off-by: XZ <834756128@qq.com>
Signed-off-by: XZ <834756128@qq.com>
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit aed2d72 into dragonflyoss:main Feb 2, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants