Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: comments in neighbours function #3069

Merged
merged 24 commits into from Feb 7, 2024
Merged

Conversation

fcgxz2003
Copy link
Member

Fix comments in neighbours function.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

fcgxz2003 and others added 24 commits January 24, 2024 21:01
Signed-off-by: fcgxz2003 <834756128@qq.com>
Signed-off-by: fcgxz2003 <834756128@qq.com>
Signed-off-by: fcgxz2003 <834756128@qq.com>
Signed-off-by: fcgxz2003 <834756128@qq.com>
Signed-off-by: fcgxz2003 <834756128@qq.com>
Signed-off-by: fcgxz2003 <834756128@qq.com>
Signed-off-by: fcgxz2003 <834756128@qq.com>
Signed-off-by: fcgxz2003 <834756128@qq.com>
Signed-off-by: fcgxz2003 <834756128@qq.com>
Signed-off-by: fcgxz2003 <834756128@qq.com>
Signed-off-by: fcgxz2003 <834756128@qq.com>
Signed-off-by: fcgxz2003 <834756128@qq.com>
Signed-off-by: fcgxz2003 <834756128@qq.com>
Signed-off-by: fcgxz2003 <834756128@qq.com>
Signed-off-by: fcgxz2003 <834756128@qq.com>
Signed-off-by: XZ <834756128@qq.com>
Signed-off-by: XZ <834756128@qq.com>
Signed-off-by: XZ <834756128@qq.com>
Signed-off-by: XZ <834756128@qq.com>
Signed-off-by: XZ <834756128@qq.com>
Signed-off-by: XZ <834756128@qq.com>
Signed-off-by: XZ <834756128@qq.com>
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bd57994) 51.92% compared to head (c7731db) 51.91%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3069      +/-   ##
==========================================
- Coverage   51.92%   51.91%   -0.01%     
==========================================
  Files         163      163              
  Lines       18558    18558              
==========================================
- Hits         9636     9635       -1     
- Misses       8260     8261       +1     
  Partials      662      662              
Flag Coverage Δ
Object-compatibility-e2etests ∅ <ø> (∅)
e2etests ∅ <ø> (∅)
unittests 51.91% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
scheduler/networktopology/network_topology.go 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 3a05eb6 into dragonflyoss:main Feb 7, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants