New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add unit tests for manager handlers #3202
Conversation
@gaius-qi So far I've written unit tests for |
2261749
to
6594bea
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3202 +/- ##
==========================================
+ Coverage 52.06% 52.78% +0.72%
==========================================
Files 173 192 +19
Lines 19382 20341 +959
==========================================
+ Hits 10091 10738 +647
- Misses 8585 8800 +215
- Partials 706 803 +97
Flags with carried forward coverage won't be shown. Click here to find out more. |
@BruceAko It is also draft. Have you finished PR? |
f61bf7b
to
e263888
Compare
db8194f
to
08f5acc
Compare
Signed-off-by: BruceAko <chongzhi@hust.edu.cn>
08f5acc
to
15787ba
Compare
@gaius-qi I have finished PR now. Please take a look. |
@BruceAko Can you add unit tests for |
Signed-off-by: BruceAko <chongzhi@hust.edu.cn>
Signed-off-by: BruceAko <chongzhi@hust.edu.cn>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Add unit tests for manager handlers.
Related Issue
fix #2705
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist