Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multiple registries support docs #481

Merged
merged 1 commit into from Jul 22, 2021
Merged

Update multiple registries support docs #481

merged 1 commit into from Jul 22, 2021

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Jul 21, 2021

Signed-off-by: Jim Ma majinjing3@gmail.com

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Jim Ma <majinjing3@gmail.com>
@jim3ma jim3ma requested a review from a team as a code owner July 21, 2021 06:44
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2021

Codecov Report

Merging #481 (4fd64e5) into main (8efafd8) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #481      +/-   ##
==========================================
- Coverage   36.39%   36.38%   -0.02%     
==========================================
  Files          90       90              
  Lines        7009     7009              
==========================================
- Hits         2551     2550       -1     
- Misses       4091     4095       +4     
+ Partials      367      364       -3     
Flag Coverage Δ
e2etests ∅ <ø> (∅)
unittests 36.38% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_stream.go 54.77% <0.00%> (-1.11%) ⬇️
client/daemon/peer/peertask_stream_callback.go 64.55% <0.00%> (+2.53%) ⬆️

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim3ma jim3ma merged commit 0c24c87 into main Jul 22, 2021
@jim3ma jim3ma deleted the feature/update-docs branch July 22, 2021 06:08
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
Signed-off-by: Jim Ma <majinjing3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants