Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rescheduler parent/children later when no candidates and add schedule log #497

Merged
merged 12 commits into from
Jul 27, 2021

Conversation

244372610
Copy link
Contributor

@244372610 244372610 commented Jul 26, 2021

Description

If no parent node is available, the node is inserted into the queue to be scheduled and rescheduled later

Related Issue

fix #498

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
@244372610 244372610 requested a review from a team as a code owner July 26, 2021 08:00
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2021

Codecov Report

Merging #497 (227bd9d) into main (2b18530) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #497   +/-   ##
=======================================
  Coverage   39.52%   39.53%           
=======================================
  Files          81       81           
  Lines        6284     6285    +1     
=======================================
+ Hits         2484     2485    +1     
  Misses       3441     3441           
  Partials      359      359           
Flag Coverage Δ
e2etests ∅ <ø> (∅)
unittests 39.53% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scheduler/config/config.go 0.00% <0.00%> (ø)
client/daemon/peer/peertask_base.go 32.39% <100.00%> (+0.15%) ⬆️
manager/searcher/search.go
manager/searcher/searcher.go 82.05% <0.00%> (ø)

@244372610 244372610 changed the title Feature/scheduler log Rescheduler parent/children later when no candidates and add schedule log Jul 26, 2021
scheduler/core/events.go Outdated Show resolved Hide resolved
Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
…as download fail/success and say leave

Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
…as download fail/success and say leave

Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
jim3ma
jim3ma previously approved these changes Jul 26, 2021
Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim3ma jim3ma merged commit 733962f into main Jul 27, 2021
@jim3ma jim3ma deleted the feature/schedulerLog branch July 27, 2021 03:20
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
… log (#497)

Signed-off-by: santong <weipeng.swp@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

schedule return 5009 first download
4 participants