Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: remove proto redundant field #508

Merged
merged 5 commits into from
Jul 29, 2021
Merged

feature: remove proto redundant field #508

merged 5 commits into from
Jul 29, 2021

Conversation

garfield009
Copy link
Collaborator

Signed-off-by: zuozheng.hzz zuozheng.hzz@alibaba-inc.com

Description

Related Issue

#496

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: zuozheng.hzz <zuozheng.hzz@alibaba-inc.com>
Signed-off-by: zuozheng.hzz <zuozheng.hzz@alibaba-inc.com>
Signed-off-by: zuozheng.hzz <zuozheng.hzz@alibaba-inc.com>
Signed-off-by: zuozheng.hzz <zuozheng.hzz@alibaba-inc.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2021

Codecov Report

Merging #508 (196d8a5) into main (e655635) will decrease coverage by 0.40%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #508      +/-   ##
==========================================
- Coverage   39.59%   39.18%   -0.41%     
==========================================
  Files          81       81              
  Lines        6284     6285       +1     
==========================================
- Hits         2488     2463      -25     
- Misses       3437     3464      +27     
+ Partials      359      358       -1     
Flag Coverage Δ
e2etests ∅ <ø> (∅)
unittests 39.18% <80.00%> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cdnsystem/server/service/cdn_seed_server.go 0.00% <0.00%> (ø)
client/daemon/peer/peertask_reuse.go 0.00% <0.00%> (ø)
client/daemon/service/manager.go 31.68% <ø> (-1.33%) ⬇️
client/daemon/peer/peertask_file.go 53.65% <100.00%> (ø)
client/daemon/peer/peertask_stream.go 54.77% <100.00%> (-2.21%) ⬇️
client/daemon/transport/transport.go 75.53% <100.00%> (ø)
internal/idgen/task_id.go 100.00% <100.00%> (ø)
client/daemon/peer/peertask_stream_callback.go 44.30% <0.00%> (-20.26%) ⬇️
client/daemon/peer/piece_manager.go 65.44% <0.00%> (-1.63%) ⬇️

Signed-off-by: zuozheng.hzz <zuozheng.hzz@alibaba-inc.com>
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garfield009 garfield009 merged commit 70e4207 into main Jul 29, 2021
@garfield009 garfield009 deleted the feature/fixproto branch July 29, 2021 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants