Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: change tar-rs to upstream version #1396

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

adamqqqplay
Copy link
Member

Relevant Issue (if applicable)

#1387 #1391

Details

Since upstream tar-rs merged our fix for reading large uids/gids from
the PAX extension, so change tar-rs back to the upstream version.

Update tar-rs dependency xattr to 1.0.1 as well.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

This change will be automatically generated during make.

Signed-off-by: Qinqi Qu <quqinqi@linux.alibaba.com>
@adamqqqplay adamqqqplay requested a review from imeoer August 8, 2023 06:49
@adamqqqplay adamqqqplay requested a review from a team as a code owner August 8, 2023 06:49
@adamqqqplay adamqqqplay requested review from liubin and jiangliu and removed request for a team August 8, 2023 06:49
@anolis-bot
Copy link
Collaborator

@adamqqqplay , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/89676

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #1396 (96e9f86) into master (34ee825) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1396      +/-   ##
==========================================
- Coverage   46.31%   46.30%   -0.01%     
==========================================
  Files         122      122              
  Lines       38077    38077              
  Branches    38077    38077              
==========================================
- Hits        17635    17633       -2     
- Misses      19516    19519       +3     
+ Partials      926      925       -1     

see 2 files with indirect coverage changes

Since upstream tar-rs merged our fix for reading large uids/gids from
the PAX extension, so change tar-rs back to the upstream version.

Update tar-rs dependency xattr to 1.0.1 as well.

Signed-off-by: Qinqi Qu <quqinqi@linux.alibaba.com>
@anolis-bot
Copy link
Collaborator

@adamqqqplay , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@jiangliu jiangliu merged commit f3cdd07 into dragonflyoss:master Aug 8, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants