Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update tar-rs to handle very large uid/gid in image unpack #1387

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

adamqqqplay
Copy link
Member

Relevant Issue (if applicable)

alexcrichton/tar-rs#332

Details

update tar-rs to support read large uid/gid from PAX extensions to fix very large UIDs/GIDs (>=2097151, limit of USTAR tar) lost in PAX style tar during unpack.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@adamqqqplay adamqqqplay requested a review from imeoer August 2, 2023 08:16
@adamqqqplay adamqqqplay requested a review from a team as a code owner August 2, 2023 08:16
@adamqqqplay adamqqqplay requested review from liubogithub and hsiangkao and removed request for a team August 2, 2023 08:16
@anolis-bot
Copy link
Collaborator

@adamqqqplay , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/88468

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #1387 (98548ba) into master (4876289) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1387      +/-   ##
==========================================
- Coverage   46.31%   46.31%   -0.01%     
==========================================
  Files         122      122              
  Lines       38071    38071              
  Branches    38071    38071              
==========================================
- Hits        17634    17632       -2     
  Misses      19513    19513              
- Partials      924      926       +2     

see 4 files with indirect coverage changes

@@ -107,3 +107,6 @@ backend-s3 = ["nydus-storage/backend-s3"]

[workspace]
members = ["api", "builder", "clib", "rafs", "storage", "service", "utils"]

[patch.crates-io]
tar = { git = "https://github.com/nydusaccelerator/tar-rs.git" }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment here explaining why we need to use the forked code.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, comment added.

@anolis-bot
Copy link
Collaborator

@adamqqqplay , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@anolis-bot
Copy link
Collaborator

@adamqqqplay , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/88487

@anolis-bot
Copy link
Collaborator

@adamqqqplay , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@liubogithub
Copy link
Collaborator

It's important to have a regression test for a tricky issue like this.

But I think we can go without it for now.

update tar-rs to support read large uid/gid from PAX extensions to
fix very large UIDs/GIDs (>=2097151, limit of USTAR tar) lost in
PAX style tar during unpack.

Signed-off-by: Qinqi Qu <quqinqi@linux.alibaba.com>
@anolis-bot
Copy link
Collaborator

@adamqqqplay , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/88660

@adamqqqplay
Copy link
Member Author

It's important to have a regression test for a tricky issue like this.

But I think we can go without it for now.

@liubogithub I added a test image at: ghcr.io/dragonflyoss/image-service/pax-uid-test to verify this is fixed.

@anolis-bot
Copy link
Collaborator

@adamqqqplay , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@adamqqqplay
Copy link
Member Author

Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants