Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: remove useless test files #1450

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Conversation

imeoer
Copy link
Collaborator

@imeoer imeoer commented Oct 24, 2023

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

Please describe the details of PullRequest.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@imeoer imeoer requested review from a team as code owners October 24, 2023 02:16
@imeoer imeoer requested review from bergwolf, jiangliu and gaius-qi and removed request for a team October 24, 2023 02:16
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #1450 (4917d09) into master (f55d2c9) will decrease coverage by 1.97%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1450      +/-   ##
==========================================
- Coverage   46.34%   44.37%   -1.97%     
==========================================
  Files         123      123              
  Lines       38896    38896              
  Branches    38896    38896              
==========================================
- Hits        18026    17261     -765     
- Misses      19898    20695     +797     
+ Partials      972      940      -32     

see 11 files with indirect coverage changes

@bergwolf
Copy link
Member

The code coverage is down by -1.97%. Does it mean that we haven't covered all the cases that are tested by either the python test or the rust smoke test?

@adamqqqplay
Copy link
Member

The code coverage is down by -1.97%. Does it mean that we haven't covered all the cases that are tested by either the python test or the rust smoke test?

Currently, we only count unit test coverage in this project.

@imeoer
Copy link
Collaborator Author

imeoer commented Oct 24, 2023

@bergwolf This may be due to the codecov CI tests failing for a period of time. (The repository name has been changed to nydus.) —— from @adamqqqplay

The python integration test is too long without maintenance, it should
be replaced with the go integration test in smoke/tests.

Signed-off-by: Yan Song <yansong.ys@antgroup.com>
The rust integration test has been replaced with the go integration
test in smoke/tests, let's remove it.

Signed-off-by: Yan Song <yansong.ys@antgroup.com>
Copy link
Member

@adamqqqplay adamqqqplay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Desiki-high Desiki-high left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Desiki-high Desiki-high merged commit 55bba9d into dragonflyoss:master Oct 31, 2023
23 of 24 checks passed
Desiki-high added a commit to Desiki-high/nydus that referenced this pull request Nov 2, 2023
Since dragonflyoss#1450, we have remove the Integration Test.
The files in `tests` directory is useless.

Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants