Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: fix unsupported dummy cache type #1458

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

imeoer
Copy link
Collaborator

@imeoer imeoer commented Oct 31, 2023

The dummycache type is missed to handle in config validation:

ERROR [/src/fusedev.rs:595] service mount error: RAFS failed to handle request, Failed to load config: failed to parse configuration information`
ERROR [/src/error.rs:18] Stack:
   0: backtrace::backtrace::trace
   1: backtrace::capture::Backtrace::new

ERROR [/src/error.rs:19] Error:
        Rafs(LoadConfig(Custom { kind: InvalidInput, error: "failed to parse configuration information" }))
        at service/src/fusedev.rs:596
ERROR [src/bin/nydusd/main.rs:525] Failed in starting daemon:
Error: Custom { kind: Other, error: "" }

Fix #1456

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

Please describe the details of PullRequest.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

The dummycache type is missed to handle in config validation:

```
ERROR [/src/fusedev.rs:595] service mount error: RAFS failed to handle request, Failed to load config: failed to parse configuration information`
ERROR [/src/error.rs:18] Stack:
   0: backtrace::backtrace::trace
   1: backtrace::capture::Backtrace::new

ERROR [/src/error.rs:19] Error:
        Rafs(LoadConfig(Custom { kind: InvalidInput, error: "failed to parse configuration information" }))
        at service/src/fusedev.rs:596
ERROR [src/bin/nydusd/main.rs:525] Failed in starting daemon:
Error: Custom { kind: Other, error: "" }
```

Signed-off-by: Yan Song <yansong.ys@antgroup.com>
@imeoer imeoer requested a review from a team as a code owner October 31, 2023 01:11
@imeoer imeoer requested review from jiangliu, gaius-qi and changweige and removed request for a team October 31, 2023 01:11
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #1458 (3f89da5) into master (f55d2c9) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1458      +/-   ##
==========================================
- Coverage   46.34%   46.33%   -0.02%     
==========================================
  Files         123      123              
  Lines       38896    38896              
  Branches    38896    38896              
==========================================
- Hits        18026    18022       -4     
- Misses      19898    19899       +1     
- Partials      972      975       +3     
Files Coverage Δ
api/src/config.rs 71.36% <0.00%> (-0.08%) ⬇️

... and 3 files with indirect coverage changes

Copy link
Member

@adamqqqplay adamqqqplay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@imeoer imeoer merged commit 34a09d8 into dragonflyoss:master Oct 31, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nydusd can't mount with dummycache backend
2 participants