Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action: get latest tag by github api #1468

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

Desiki-high
Copy link
Member

@Desiki-high Desiki-high commented Nov 3, 2023

Details

Use Github API to get the latest tag of nydus, and used in smoke/integration-test.

Enhancement #1462.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@Desiki-high Desiki-high requested a review from a team as a code owner November 3, 2023 06:03
@Desiki-high Desiki-high requested review from imeoer, jiangliu and hsiangkao and removed request for a team November 3, 2023 06:03
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #1468 (4c43d9e) into master (8b81a99) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1468      +/-   ##
==========================================
- Coverage   53.80%   53.80%   -0.01%     
==========================================
  Files         123      123              
  Lines       40172    40172              
  Branches    40172    40172              
==========================================
- Hits        21614    21613       -1     
  Misses      17333    17333              
- Partials     1225     1226       +1     

see 2 files with indirect coverage changes

@Desiki-high Desiki-high force-pushed the action/release_tag branch 2 times, most recently from 7ed6f6d to 4b78ad6 Compare November 3, 2023 06:21
@Desiki-high
Copy link
Member Author

If the latest release is stable, I think this patch can work batter. cc@imeoer.

@Desiki-high Desiki-high force-pushed the action/release_tag branch 2 times, most recently from c71d41e to 546d50d Compare November 5, 2023 13:45
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others LGTM, thanks!

@Desiki-high Desiki-high force-pushed the action/release_tag branch 6 times, most recently from 5df8a6f to 8df6d71 Compare November 6, 2023 06:07
Use https://api.github.com/repos/Dragonflyoss/nydus/releases/latest to get the
latest tag of nydus, and used in smoke/integration-test.

Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
@Desiki-high
Copy link
Member Author

In Github Action, the environment variable can't share between different steps in the same job, see https://github.com/dragonflyoss/nydus/actions/runs/6766960684/job/18388873567. So we need to export
NYDUS_STABLE_VERSIO twice. cc @imeoer .

Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@imeoer imeoer merged commit 2fb2934 into dragonflyoss:master Nov 7, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants