Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib: correct parameter name #1470

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

An-DJ
Copy link
Contributor

@An-DJ An-DJ commented Nov 3, 2023

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

suffix -> prefix

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Signed-off-by: Junduo Dong <andj4cn@gmail.com>
@An-DJ An-DJ requested a review from a team as a code owner November 3, 2023 14:36
@An-DJ An-DJ requested review from liubogithub, luodw and hsiangkao and removed request for a team November 3, 2023 14:36
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #1470 (8f11688) into master (240af3e) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1470      +/-   ##
==========================================
- Coverage   53.79%   53.75%   -0.05%     
==========================================
  Files         123      123              
  Lines       40172    40172              
  Branches    40172    40172              
==========================================
- Hits        21612    21595      -17     
- Misses      17334    17350      +16     
- Partials     1226     1227       +1     

see 5 files with indirect coverage changes

Copy link
Member

@Desiki-high Desiki-high left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@imeoer imeoer merged commit 8b81a99 into dragonflyoss:master Nov 6, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants