Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smoke: add performance test #1485

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Conversation

Desiki-high
Copy link
Member

@Desiki-high Desiki-high commented Nov 17, 2023

Relevant Issue (if applicable)

#1460

Details

  1. Remove old benchmark in smoke test.
  2. Add a new performance test in smoke test, written in Golang to make it easy to maintain.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@Desiki-high Desiki-high requested review from a team as code owners November 17, 2023 11:30
@Desiki-high Desiki-high requested review from bergwolf, imeoer and changweige and removed request for a team November 17, 2023 11:30
@Desiki-high
Copy link
Member Author

Desiki-high commented Nov 17, 2023

I will add tests for v5 and zran later.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #1485 (05ce5eb) into master (e2b131e) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1485   +/-   ##
=======================================
  Coverage   62.50%   62.50%           
=======================================
  Files         123      123           
  Lines       43148    43148           
  Branches    43148    43148           
=======================================
  Hits        26970    26970           
  Misses      14870    14870           
  Partials     1308     1308           

see 1 file with indirect coverage changes

@Desiki-high Desiki-high force-pushed the smoke/perf branch 2 times, most recently from 35352e2 to 7072794 Compare November 18, 2023 13:23
@Desiki-high
Copy link
Member Author

PTAL. @imeoer

misc/performance/prepare.sh Outdated Show resolved Hide resolved
smoke/Makefile Outdated Show resolved Hide resolved
.github/workflows/smoke.yml Outdated Show resolved Hide resolved
We will rewrite it in performance_test with golang

Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
@Desiki-high Desiki-high force-pushed the smoke/perf branch 2 times, most recently from 76796d7 to 3d6f7ff Compare November 22, 2023 10:14
Add performance test to make sure there don't have performance descend

Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
@jiangliu jiangliu merged commit f21fe67 into dragonflyoss:master Nov 27, 2023
14 checks passed
@Desiki-high Desiki-high deleted the smoke/perf branch November 28, 2023 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants