Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go work: save go.work.sum locally #1491

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Conversation

Desiki-high
Copy link
Member

Details

go.work.sum always changes too large. We only need it to work well locally. See #1490 (comment).

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

`go.work.sum` always changes too large. We only need it to work well locally.

Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
@Desiki-high Desiki-high requested a review from a team as a code owner November 22, 2023 04:07
@Desiki-high Desiki-high requested review from bergwolf, liubin and imeoer and removed request for a team November 22, 2023 04:07
smoke/go.sum Show resolved Hide resolved
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #1491 (c98d27c) into master (767adcf) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1491      +/-   ##
==========================================
- Coverage   62.51%   62.50%   -0.02%     
==========================================
  Files         123      123              
  Lines       43148    43148              
  Branches    43148    43148              
==========================================
- Hits        26975    26970       -5     
  Misses      14870    14870              
- Partials     1303     1308       +5     

see 2 files with indirect coverage changes

Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@imeoer imeoer merged commit e2b131e into dragonflyoss:master Nov 22, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants