Let targz type conversions support multi-stream gzip #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyfjeff
requested review from
liubogithub,
luodw and
hsiangkao
and removed request for
a team
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1493 +/- ##
==========================================
+ Coverage 62.71% 62.75% +0.04%
==========================================
Files 123 123
Lines 43248 43340 +92
Branches 43248 43340 +92
==========================================
+ Hits 27122 27199 +77
- Misses 14817 14827 +10
- Partials 1309 1314 +5
|
zyfjeff
changed the title
|
Otherwise LGTM！ |
|
A merge commit needs to be removed. |
zyfjeff
force-pushed
the
fix-bgzip
branch
2 times, most recently
from
6d47a48
to
4363308
Compare
Signed-off-by: zyfjeff <zyfjeff@linux.alibaba-inc.com>
code reference https://github.com/madler/zlib/blob/master/examples/zran.c at present, zran and normal targz do not consider the support for multi stream gzip when decompressing, so there will be problems when encountering this kind of image, and this PR is used to support the gzip multi-stream. Signed-off-by: zyfjeff <zyfjeff@linux.alibaba-inc.com>
imeoer
approved these changes
Nov 29, 2023
jiangliu
approved these changes
Nov 29, 2023
| // The input does not have a complete trailer. | ||
| return Err(eio!("the input does not have a complete gzip trailer")); | ||
| } | ||
| // Use inflate to skip the gzip header and resume the raw inflate there. |
There was a problem hiding this comment.
How about separate out it as a helper？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Types of changes
What types of changes does your PullRequest introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.