Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action: update rust-cache and setup-go version #1498

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

Desiki-high
Copy link
Member

Relevant Issue (if applicable)

N/A

Details

  1. update rust-cache and setup-go version
  2. shared more cargo caches by shared-key: Linux-cargo-amd64, especially between release and smoke.
  3. use setup-go@v4 cache and select go version by go.work.
  4. disable rust-cache of Smoke Test in pr, only save the rust-cache in master.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

1. update Swatinem/rust-cache to v2.7.0.
2. share caches betwwen jobs in release, smoke, convert and benchmark.
3. save rust cache only in master branch in smoke test.

Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
When update setup-go to v4, it can cache by itself. And select go version
by `go.work`.

Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
@Desiki-high Desiki-high requested a review from a team as a code owner November 30, 2023 05:15
@Desiki-high Desiki-high requested review from bergwolf, liubogithub and gaius-qi and removed request for a team November 30, 2023 05:15
@Desiki-high Desiki-high changed the title acrion: update rust-cache and setup-go version action: update rust-cache and setup-go version Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #1498 (e0942b2) into master (f5001bb) will increase coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1498      +/-   ##
==========================================
+ Coverage   62.72%   62.75%   +0.03%     
==========================================
  Files         123      123              
  Lines       43340    43340              
  Branches    43340    43340              
==========================================
+ Hits        27183    27199      +16     
+ Misses      14842    14827      -15     
+ Partials     1315     1314       -1     

see 4 files with indirect coverage changes

@Desiki-high
Copy link
Member Author

Nydus-build is slow because of the new cache name, it will be faster next time.

Copy link
Member

@adamqqqplay adamqqqplay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@imeoer imeoer merged commit a1ad70a into dragonflyoss:master Dec 1, 2023
20 checks passed
Desiki-high added a commit to Desiki-high/nydus that referenced this pull request Dec 1, 2023
Since dragonflyoss#1498, we will never save caches
in pr, so we don't need clean-cache.

Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
@Desiki-high Desiki-high mentioned this pull request Dec 1, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants