Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: nydus-sandbox.yaml add uid #1499

Merged
merged 1 commit into from
Nov 30, 2023
Merged

docs: nydus-sandbox.yaml add uid #1499

merged 1 commit into from
Nov 30, 2023

Conversation

whygyc
Copy link
Contributor

@whygyc whygyc commented Nov 30, 2023

Relevant Issue (if applicable)

Fix #1496

Details

To avoid the inability to delete pods created by crictl, add the UID to the example yaml.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

@whygyc
docs: nydus-sandbox.yaml add uid
12566f7 
Signed-off-by: wuheng <wuheng@kylinos.cn>
@whygyc whygyc requested a review from a team as a code owner November 30, 2023 06:14
@whygyc whygyc requested review from liubogithub, luodw and adamqqqplay and removed request for a team November 30, 2023 06:14
adamqqqplay
adamqqqplay approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@adamqqqplay adamqqqplay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help!

@adamqqqplay adamqqqplay merged commit 3f5c2c8 into dragonflyoss:master Nov 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamqqqplay adamqqqplay adamqqqplay approved these changes

@liubogithub liubogithub Awaiting requested review from liubogithub liubogithub is a code owner automatically assigned from dragonflyoss/nydus-reviewers

@luodw luodw Awaiting requested review from luodw luodw is a code owner automatically assigned from dragonflyoss/nydus-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The sandbox.yaml reference in the containerd-env-setup.md document has issues
2 participants
@whygyc @adamqqqplay