Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add nydusify commit command #1543

Merged
merged 4 commits into from
Mar 14, 2024

Conversation

PerseidMeteor
Copy link
Contributor

Relevant Issue (if applicable)

support nydus commit operation

Details

Please describe the details of PullRequest.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@imeoer
Copy link
Collaborator

imeoer commented Feb 21, 2024

Thanks for the implementation! Please also add a test case in https://github.com/dragonflyoss/nydus/tree/master/smoke/tests (maybe create a commit_test.go ?).

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 61.29%. Comparing base (a0ec880) to head (5f2790f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1543      +/-   ##
==========================================
- Coverage   61.35%   61.29%   -0.06%     
==========================================
  Files         144      144              
  Lines       47001    47035      +34     
  Branches    44537    44537              
==========================================
- Hits        28837    28832       -5     
- Misses      16685    16719      +34     
- Partials     1479     1484       +5     
Files Coverage Δ
contrib/nydusify/cmd/nydusify.go 14.32% <0.00%> (-0.77%) ⬇️

... and 2 files with indirect coverage changes

@PerseidMeteor
Copy link
Contributor Author

Thanks for the implementation! Please also add a test case in https://github.com/dragonflyoss/nydus/tree/master/smoke/tests (maybe create a commit_test.go ?).

I am sorry for I was too late because of my Spring Festival holiday. Commit smoke test was added.
Have a nice day!

@PerseidMeteor PerseidMeteor marked this pull request as ready for review February 26, 2024 05:56
@PerseidMeteor PerseidMeteor requested a review from a team as a code owner February 26, 2024 05:56
@PerseidMeteor PerseidMeteor requested review from jiangliu, ccx1024cc and Desiki-high and removed request for a team February 26, 2024 05:56
@davidstack
Copy link

very nice pr

@Desiki-high
Copy link
Member

Thanks for your pr, please fix the golang-lint.

@PerseidMeteor PerseidMeteor force-pushed the feat-nydus-commit branch 2 times, most recently from e09488f to 18b4bdd Compare February 26, 2024 14:33
smoke/tests/commit_test.go Outdated Show resolved Hide resolved
smoke/tests/commit_test.go Outdated Show resolved Hide resolved
smoke/tests/commit_test.go Outdated Show resolved Hide resolved
smoke/tests/commit_test.go Outdated Show resolved Hide resolved
smoke/tests/commit_test.go Outdated Show resolved Hide resolved
contrib/nydusify/pkg/utils/constant.go Outdated Show resolved Hide resolved
contrib/nydusify/pkg/commiter/commiter.go Outdated Show resolved Hide resolved
contrib/nydusify/pkg/commiter/commiter.go Outdated Show resolved Hide resolved
contrib/nydusify/pkg/commiter/commiter.go Outdated Show resolved Hide resolved
contrib/nydusify/pkg/commiter/commiter.go Outdated Show resolved Hide resolved
contrib/nydusify/pkg/commiter/commiter.go Outdated Show resolved Hide resolved
contrib/nydusify/pkg/commiter/commiter.go Outdated Show resolved Hide resolved
contrib/nydusify/pkg/commiter/commiter.go Outdated Show resolved Hide resolved
contrib/nydusify/pkg/commiter/diff/overlay_linux.go Outdated Show resolved Hide resolved
contrib/nydusify/pkg/commiter/diff/diff.go Outdated Show resolved Hide resolved
contrib/nydusify/pkg/commiter/nsenter.go Outdated Show resolved Hide resolved
@davidstack
Copy link

@imeoer which release will contain this pr? we are waiting for this pr for a long time. thanks

@imeoer
Copy link
Collaborator

imeoer commented Feb 27, 2024

@imeoer which release will contain this pr? we are waiting for this pr for a long time. thanks

Thanks for waiting, it should be included in the next release, v2.3.0.

@PerseidMeteor PerseidMeteor force-pushed the feat-nydus-commit branch 4 times, most recently from e3e67fc to 4455f1b Compare February 28, 2024 08:15
@PerseidMeteor PerseidMeteor deleted the feat-nydus-commit branch February 29, 2024 07:53
@PerseidMeteor PerseidMeteor restored the feat-nydus-commit branch February 29, 2024 11:41
@PerseidMeteor PerseidMeteor force-pushed the feat-nydus-commit branch 2 times, most recently from b096c02 to 3209f72 Compare March 5, 2024 08:35
@PerseidMeteor PerseidMeteor requested a review from a team as a code owner March 5, 2024 12:25
@PerseidMeteor PerseidMeteor requested review from liubin and changweige and removed request for a team March 5, 2024 12:25
@PerseidMeteor PerseidMeteor force-pushed the feat-nydus-commit branch 5 times, most recently from c37c165 to 111eedd Compare March 5, 2024 14:08
.github/workflows/smoke.yml Outdated Show resolved Hide resolved
contrib/nydusify/cmd/nydusify.go Outdated Show resolved Hide resolved
contrib/nydusify/cmd/nydusify.go Outdated Show resolved Hide resolved
contrib/nydusify/cmd/nydusify.go Outdated Show resolved Hide resolved
contrib/nydusify/cmd/nydusify.go Outdated Show resolved Hide resolved
smoke/tests/commit_test.go Outdated Show resolved Hide resolved
smoke/tests/commit_test.go Outdated Show resolved Hide resolved
smoke/tests/commit_test.go Outdated Show resolved Hide resolved
smoke/tests/commit_test.go Show resolved Hide resolved
smoke/tests/commit_test.go Outdated Show resolved Hide resolved
@imeoer
Copy link
Collaborator

imeoer commented Mar 11, 2024

image

It seems the CI broken.

ported  capability of get and write diff between overlayfs upper and lower.

Signed-off-by: YuQiang <y_q_email@163.com>
add nydusify commit command to commit a nydus container into nydus image

Signed-off-by: YuQiang <y_q_email@163.com>
@PerseidMeteor PerseidMeteor force-pushed the feat-nydus-commit branch 3 times, most recently from 46317ad to 609e0fa Compare March 13, 2024 07:32
@PerseidMeteor
Copy link
Contributor Author

image

It seems the CI broken.

It made me confused. Is there any idea to slove this problem?

@PerseidMeteor PerseidMeteor force-pushed the feat-nydus-commit branch 3 times, most recently from 02ba2c2 to 5f2790f Compare March 13, 2024 09:10
Signed-off-by: YuQiang <y_q_email@163.com>
remove misc/performance/prepare.sh and misc/performance/prepare.sh and merge to misc/prepare.sh

Signed-off-by: YuQiang <y_q_email@163.com>
@imeoer imeoer merged commit ae842f9 into dragonflyoss:master Mar 14, 2024
25 checks passed
@PerseidMeteor PerseidMeteor deleted the feat-nydus-commit branch March 14, 2024 03:14
@imeoer imeoer mentioned this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants