nydus-snapshotter: fix recreate daemon config/socket dir #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when create multiple containers with same image, nydus-snapshotter will create daemon config/socket dir per container, most of them can not be deleted even though the image is deleted. Signed-off-by: luodaowen.backend <luodaowen.backend@bytedance.com>
bergwolf
approved these changes
Dec 21, 2021
|
Discussed with @luodw offline, so the issue is that when we create more containers with the same image in non-shared daemon mode, we would create extra directories in |
|
Thanks @luodw ! |
changweige
reviewed
Dec 21, 2021
| @@ -373,7 +377,10 @@ func (fs *filesystem) createSharedDaemon(snapshotID string, imageID string) (*da | |||
| d *daemon.Daemon | |||
| err error | |||
| ) | |||
|
|
|||
| d, _ = fs.manager.GetBySnapshotID(snapshotID) | |||
There was a problem hiding this comment.
Though, seems it is also possible that a race window exists where two goroutines are creating daemons with those directories created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when create multiple containers with same image, nydus-snapshotter will
create daemon config/socket dir per container, most of them can not be
deleted even though the image is deleted.
Signed-off-by: luodaowen.backend luodaowen.backend@bytedance.com