Fix failing PHPStan issue (#130)

dragonmantank · Jan 5, 2022 · 7a364e7 · 7a364e7
1 parent 6a9fccc
commit 7a364e7
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -22,10 +22,17 @@ jobs:
       - name: "Checkout"
         uses: actions/checkout@v2
 
-      - name: PHPStan
-        uses: docker://oskarstark/phpstan-ga
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
         with:
-          args: analyse --level=max src
+          php-version: ${{ matrix.php }}
+          extensions: json, mbstring
+
+      - name: Install dependencies
+        run: composer update --prefer-dist --no-interaction
+
+      - name: Start Static Analyze
+        run: composer phpstan -n
 
   phpunit:
     name: PHPUnit - PHP ${{ matrix.php }}

diff --git a/composer.json b/composer.json
@@ -35,7 +35,7 @@
         "mtdowling/cron-expression": "^1.0"
     },
     "scripts": {
-        "phpstan": "./vendor/bin/phpstan analyse -l max src",
+        "phpstan": "./vendor/bin/phpstan analyse -l max src tests",
         "test": "phpunit"
     }
 }
diff --git a/tests/Cron/CronExpressionTest.php b/tests/Cron/CronExpressionTest.php
@@ -652,7 +652,7 @@ public function testNextRunDateShouldNotAddMinutes(): void
     /**
      * Tests the getParts function.
      */
-    public function testGetParts()
+    public function testGetParts(): void
     {
         $e = CronExpression::factory('0 22 * * 1-5');
         $parts = $e->getParts();