Fixed #134, no transitions now immediately returns null

dragonmantank · Jan 18, 2022 · be85b3f · be85b3f
1 parent 63f2a76
commit be85b3f
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,16 @@
 # Change Log
 
+## [3.3.1] - 2022-01-18
+
+### Added
+- N/A
+
+### Changed
+- N/A
+
+### Fixed
+- Fixed issue when timezones had no transition, which can occur over very short timespans (#134)
+
 ## [3.3.0] - 2022-01-13
 
 ### Added

diff --git a/src/Cron/HoursField.php b/src/Cron/HoursField.php
@@ -92,6 +92,9 @@ public function getPastTransition(DateTimeInterface $date): ?array
                 $dtLimitStart->getTimestamp(),
                 $dtLimitEnd->getTimestamp()
             );
+            if ($this->transitions === false) {
+                return null;
+            }
             $this->transitionsStart = $dtLimitStart->getTimestamp();
             $this->transitionsEnd = $dtLimitEnd->getTimestamp();
         }

diff --git a/tests/Cron/CronExpressionTest.php b/tests/Cron/CronExpressionTest.php
@@ -806,4 +806,11 @@ public function testItWillFailToUnregisterADefaultExpression(): void
 
         CronExpression::unregisterAlias('@daily');
     }
+
+    public function testIssue134ForeachInvalidArgumentOnHours()
+    {
+        $cron = new CronExpression('0 0 1 1 *');
+        $prev = $cron->getPreviousRunDate(new \DateTimeImmutable('2021-09-07T09:36:00Z'));
+        $this->assertEquals(new \DateTime('2021-01-01 00:00:00'), $prev);
+    }
 }