Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

set phpstan to level max and fix issues #93

Merged
merged 5 commits into from Nov 24, 2020

Conversation

oallain
Copy link

@oallain oallain commented Oct 5, 2020

Hello,

I do:

It improve DX 馃殌

@oallain
Copy link
Author

oallain commented Oct 6, 2020

Hello @dragonmantank,

I use this librairie and i love it, so i propose my first PR :)
I hope this will help you, and i'm available for more updates.

Regards

@dragonmantank
Copy link
Owner

Thanks! Could you possibly rebase on the newest master branch? After your PR was created there was an update to support PHP 8, which generated a few conflicts

@oallain
Copy link
Author

oallain commented Oct 13, 2020

Hello @dragonmantank ,

I've juste rebase on master 馃帀

I'll propose an other PR to add PHPStan chek with Github Actions.

@oallain
Copy link
Author

oallain commented Nov 13, 2020

Hello @dragonmantank

Do you have any time to review this PR?

Thanks

@dragonmantank dragonmantank merged commit faf4bc3 into dragonmantank:master Nov 24, 2020
@dragonmantank
Copy link
Owner

Manually merged this, just had a few cleanup issues due to other fixes. Thanks!

@oallain
Copy link
Author

oallain commented Nov 24, 2020

Good job @dragonmantank 馃挭
Thanks for that !

@oallain oallain deleted the phpstan-level-max branch November 24, 2020 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants