Fix macOS CI #31
Merged
Fix macOS CI #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## fix/static-linked-builds #31 +/- ##
=============================================================
- Coverage 84.89% 35.48% -49.42%
=============================================================
Files 27 26 -1
Lines 2575 2100 -475
Branches 574 699 +125
=============================================================
- Hits 2186 745 -1441
- Misses 382 1028 +646
- Partials 7 327 +320
☔ View full report in Codecov by Sentry. |
amyspark
force-pushed
the
amyspark/fix/static-linked-builds
branch
4 times, most recently
from
3890c0b
to
236bdc6
Compare
amyspark
changed the title
amyspark
force-pushed
the
amyspark/fix/static-linked-builds
branch
from
236bdc6
to
051895a
Compare
dragonmux
reviewed
Sep 4, 2023
amyspark
force-pushed
the
amyspark/fix/static-linked-builds
branch
from
051895a
to
b94e90a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋
This MR is intended to appease macOS CI. The sole issue was that there is a dynamic loader race condition with regards to the crunch that's linked to the runner by Meson (loaded with rpath) and the one that's linked to the test libraries (loaded with full path).