Fix: Upgrade and clean up CI #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… static libraries are set as the default
…ows (MSVC) workflow
…dows (MSYS2) workflow
… macOS (Apple Clang) workflow
…hat broke testCrunch++
…cOS (homebrew) workflow
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
===========================================
+ Coverage 68.76% 83.51% +14.75%
===========================================
Files 17 27 +10
Lines 1495 2674 +1179
Branches 437 784 +347
===========================================
+ Hits 1028 2233 +1205
- Misses 244 431 +187
+ Partials 223 10 -213
☔ View full report in Codecov by Sentry. |
amyspark
approved these changes
Sep 7, 2023
|
Merged, despite GitHub thinking we closed this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the state the CI for the project had gotten into via neglect and old mistakes that had been made and never fixed.
With thanks to Amy for helping fix the macOS part in this!