Skip to content

Commit

Permalink
use list comprehension (commaai#839)
Browse files Browse the repository at this point in the history
* use list comprehension

* oops index range fix
  • Loading branch information
dek3rr authored and rbiasini committed Oct 11, 2019
1 parent b773d54 commit a7bfa41
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions common/dbc.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,13 +101,8 @@ def __init__(self, fn):
defvals = defvals.replace("?",r"\?") #escape sequence in C++
defvals = defvals.split('"')[:-1]

defs = defvals[1::2]
#cleanup, convert to UPPER_CASE_WITH_UNDERSCORES
for i,d in enumerate(defs):
d = defs[i].strip().upper()
defs[i] = d.replace(" ","_")

defvals[1::2] = defs
# convert strings to UPPER_CASE_WITH_UNDERSCORES
defvals[1::2] = [d.strip().upper().replace(" ","_") for d in defvals[1::2]]
defvals = '"'+"".join(str(i) for i in defvals)+'"'

self.def_vals[ids].append((sgname, defvals))
Expand Down

0 comments on commit a7bfa41

Please sign in to comment.