[Wisp] Fix coroutine miss nmethod marking cause by work stealing. #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: NMethodMarkingClosure will do handshake to scan nmethod and mark out of safepoint. If a coroutine is steal from a not scanned thread to a scanned thread. The coroutine will miss current round of nmethod marking then collected by mistake. The above case will lead to a crash. Test Plan: all wisp tests Reviewed-by: yulei Issue: dragonwell-project#176
yuleil
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
NMethodMarkingClosure will do handshake to scan nmethod and mark out of safepoint. If a coroutine is steal from a not scanned thread to a scanned thread. The coroutine will miss current round of nmethod marking then collected by mistake. The above case will lead to a crash.
Test Plan: all wisp tests
Reviewed-by: yulei
Issue:
#176