[GC] Add option G1BarrierSimple to use simple g1 post barrier #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mmyxym
force-pushed
the
g1barriersimple
branch
4 times, most recently
from
d7ad65a
to
de0e103
Compare
| if (G1BarrierSimple) { | ||
| for (; byte <= last_byte; byte++) { | ||
| *byte = G1CardTable::dirty_card_val(); | ||
| } |
There was a problem hiding this comment.
Why not use memset(), like what we did in dragonwell11?
linade
reviewed
Jun 14, 2024
|
|
||
| __ load_byte_map_base(scratch); | ||
| __ add(start, start, scratch); | ||
| __ bind(L_loop); |
There was a problem hiding this comment.
assert(dirty_card_val == 0)
linade
reviewed
Jun 14, 2024
| __ mov64(tmp, disp); | ||
| __ addptr(addr, tmp); | ||
| __ bind(L_loop); | ||
| __ movb(Address(addr, count, Address::times_1), 0); |
There was a problem hiding this comment.
Use G1CardTable::dirty_card_val() like the rest of the code
linade
reviewed
Jun 14, 2024
| @@ -98,6 +100,36 @@ void G1BarrierSetAssembler::gen_write_ref_array_pre_barrier(MacroAssembler* masm | |||
|
|
|||
| void G1BarrierSetAssembler::gen_write_ref_array_post_barrier(MacroAssembler* masm, DecoratorSet decorators, | |||
| Register addr, Register count, Register tmp) { | |||
| #ifdef _LP64 | |||
There was a problem hiding this comment.
G1BarrierSimple seems to permit X86. What happens on that platform?
There was a problem hiding this comment.
The option will be ignored.
|
Probably not enough functional tests which will concern our coverage goals.. |
Summary: Provide option G1BarrierSimple to use simple G1 post barrier for better mutator performance Testing: CI pipeline Reviewers: yude, yifeng Issue: dragonwell-project#56
linade
reviewed
Jun 17, 2024
| @@ -177,6 +177,25 @@ void G1Arguments::initialize() { | |||
| FLAG_SET_ERGO(ParallelGCThreads, 1); | |||
| } | |||
|
|
|||
| if (G1BarrierSimple) { | |||
| #if !defined(_LP64) || !(defined(X86) || defined(AARCH64)) | |||
There was a problem hiding this comment.
x86 32bit is not supported.
There was a problem hiding this comment.
ok, took me a while to see this means !(x86_64 || aarch64)
linade
approved these changes
Jun 18, 2024
leveretconey
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Provide option G1BarrierSimple to use simple G1 post barrier for better mutator performance
Testing: CI pipeline
Reviewers: yude, yifeng
Issue: #56