[Backport] 8139457: Relax alignment of array elements #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Fei Yang <fyang@openjdk.org> Co-authored-by: Thomas Stuefe <stuefe@openjdk.org> Reviewed-by: stuefe, stefank, shade, coleenp, kdnilsen, aboldtch
…acroAssembler::allocate_array Reviewed-by: fyang
Reviewed-by: aboldtch, aph
|
|
|
As the commits are clean backports, could you please describe the additional typo change? |
doing a diff with lilliput21 branch reveals this typo |
linade
commented
Jun 20, 2024
| @@ -57,7 +57,7 @@ private static void initialize(TypeDataBase db) throws WrongTypeException { | |||
| private static long lengthOffsetInBytes=0; | |||
| private static long typeSize; | |||
|
|
|||
| // Check whether an element of a arrayOop with the given type must be | |||
| // Check whether an element of an arrayOop with the given type must be | |||
|
LGTM |
weixlu
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request backports the following patches:
8139457: Relax alignment of array elements
8327426: RISC-V: Move alignment shim into initialize_header() in C1_MacroAssembler::allocate_array
8331098: [Aarch64] Fix crash in Arrays.equals() intrinsic with -CCP
All applies cleanly. Additionally we fix one typo.
8139457 and 8331098 changes alignment requirement for array headers, and fix one bug that's caused.
8327426 is only there to make the code look more like the lilliput21 branch, so that future lilliput patches apply more easily.