[EagerAppCDS] enable classpath change by replacing given env var #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jia-wei-tang
assigned alibaba-oss, yuleil, lingjun-cg and tanghaoth90 and unassigned alibaba-oss
Summary: If user give environment vars and use `-Dcom.alibaba.cds.cp.reloc.envs`, cds will change the classpath by using given environment vars to transform some paths in classpath. Test Plan: ci jtreg jdk/test/com/alibaba/quickstart/TestEnvVariableReplay.java jdk/test/com/alibaba/quickstart/TestEnvVariableDump.java Reviewed-by: lingjun-cg, yuleil Issue: dragonwell-project#595
lingjun-cg
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: If user give environment vars and use
-Dcom.alibaba.cds.cp.reloc.envs, cds will change the classpath by using given environment vars to transform some paths in classpath.Test Plan: ci jtreg
jdk/test/com/alibaba/quickstart/TestEnvVariableReplay.java jdk/test/com/alibaba/quickstart/TestEnvVariableDump.java
Reviewed-by: lingjun-cg, yuleil
Issue: #595