[Wisp] Thread-based asynchronous IO implementation #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
joeyleeeeeee97
force-pushed
the
fileaio
branch
2 times, most recently
from
52056ad
to
e32db8c
Compare
zhengxiaolinX
approved these changes
Apr 25, 2021
| @@ -486,7 +517,17 @@ public int skipBytes(int n) throws IOException { | |||
| * @exception IOException if an I/O error occurs. | |||
| */ | |||
| public void write(int b) throws IOException { | |||
| write0(b); | |||
| if (WispAsyncIO.useAsyncIO()) { | |||
| sun.misc.SharedSecrets.getWispAsyncIOAccess().executeAsyncIO(new Callable<Integer>() { | |||
There was a problem hiding this comment.
Maybe we can remove the sun.misc.? Will look more ordered.
| Runtime.getRuntime().availableProcessors()); | ||
| MAX_POOL_SIZE = parsePositiveIntegerParameter(p, "com.alibaba.aio.maxPoolSize", | ||
| Runtime.getRuntime().availableProcessors()); | ||
| AIO_QUEUE_LIMIT = parsePositiveIntegerParameter(p, "com.alibaba.aio.queueLimit", -1); |
There was a problem hiding this comment.
I wonder about the magic number. I think we'd better use a named variable to represent the -1 and reference it here. Or if the -1 changes afterwards, we may get to change several places all together.
| MAX_POOL_SIZE = parsePositiveIntegerParameter(p, "com.alibaba.aio.maxPoolSize", | ||
| Runtime.getRuntime().availableProcessors()); | ||
| AIO_QUEUE_LIMIT = parsePositiveIntegerParameter(p, "com.alibaba.aio.queueLimit", -1); | ||
| TIMEOUT = parsePositiveIntegerParameter(p, "com.alibaba.aio.timeout", -1); |
There was a problem hiding this comment.
also this, and all hard coded -1 places
joeyleeeeeee97
force-pushed
the
fileaio
branch
5 times, most recently
from
348b7b9
to
9e2e0b1
Compare
Summary: Use ThreadPool as asynchronous IO delegate for asynchronous IO implementation. The feature can be used in Wisp flow and non-Wisp flow. Test Plan: test/com/alibaba/wisp/io/ThreadPoolAIOTest.java Reviewed-by: leiyu, zhengxiaolinX Issue: dragonwell-project/dragonwell8#213 thread local judge
|
Not necessay now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Use ThreadPool as asynchronous IO delegate for asynchronous IO implementation.
The feature can be used in Wisp flow and non-Wisp flow.
Test Plan: test/com/alibaba/wisp/io/ThreadPoolAIOTest.java
Reviewed-by: leiyu, zhengxiaolinX
Issue: dragonwell-project/dragonwell8#213