Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudposse master #2

Merged
merged 2 commits into from
Apr 18, 2022
Merged

Cloudposse master #2

merged 2 commits into from
Apr 18, 2022

Conversation

dragosmc
Copy link
Owner

what

  • Describe high-level what changed as a result of these commits (i.e. in plain-english, what do these changes mean?)
  • Use bullet points to be concise and to the point.

why

  • Provide the justifications for the changes (e.g. business case).
  • Describe why these changes were made (e.g. why do these commits fix the problem?)
  • Use bullet points to be concise and to the point.

references

  • Link to any supporting github issues or helpful documentation to add some context (e.g. stackoverflow).
  • Use closes #123, if this PR closes a GitHub issue #123

dsme94 and others added 2 commits March 21, 2022 11:31
* feat: Cross account ECR for lambda functions

* Auto Format

* Update main.tf

Co-authored-by: nitrocode <nitrocode@users.noreply.github.com>

* feat: Updating to include aws_partition and code tidy up

* Auto Format

* feat: Updating to use dynamic statement block

* Auto Format

* feat: Removing unnecessary vars

* feat: Updating README with make readme/terraform-docs

* Auto Format

* feat: Removing interpolation wrapper - better code

Co-authored-by: david.elliott <david.elliott@gov.scot>
Co-authored-by: cloudpossebot <11232728+cloudpossebot@users.noreply.github.com>
Co-authored-by: nitrocode <nitrocode@users.noreply.github.com>
 into cloudposse-master

# Conflicts:
#	main.tf
@dragosmc dragosmc merged commit daf4547 into master Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants