Omit BUILD_HOST_NAME for reproducible builds
#215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Distributions that want reproducible builds, set the SOURCE_DATE_EPOCH environment variable. In this case, we should not record the build host name to allow for bit-identical rebuilds elsewhere. This patch was done while working on reproducible builds for openSUSE.
bmwiedemann
force-pushed
the
hostname
branch
from
b435754
to
227197c
Compare
|
An alternative would be to drop |
|
Thank you @bmwiedemann for this patch, and sorry for screwing it up in the first place. The build host was an explicit wish by a community member, so I'd like to keep it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Distributions that want reproducible builds, set the
SOURCE_DATE_EPOCHenvironment variable. In this case, we should not record the build
host name to allow for bit-identical rebuilds elsewhere.
This PR was done while working on reproducible builds for openSUSE.