-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support dev comments #115
Comments
Hi @drahnr I would like to have a go at implementing this improvement please, if that's okay? |
@snasphysicist that'd be awesome! The relevant code would mostly around https://github.com/drahnr/cargo-spellcheck/blob/master/src/documentation/literal.rs#L60-L164 - currently I assume either applying another rust syntax parser (not sure how many usable there are, rust-analyzer comes to mind) would be an option, manual parsing is probably quite dire. Feel free to open a PR, I am happy to review this early and often :) |
@snasphysicist anything I can help with to get you started? |
Hi @drahnr some slow progress is being made - I've been playing with |
What you described sounds like a good path forward ( the extracted syntax parser lib of ra is https://lib.rs/crates/ra_ap_syntax ) |
Hmm maybe I am using a slightly out of date version of Neither If you're happy with the basic idea here, I'll start looking at how to integrate this into the existing |
The gist looks good! I would recommend to take a look at Most of your changes should be in Looking forward to your PR! |
Is your feature request related to a particular use-case?
Dev comments could contain spelling mistakes too.
Describe the solution you'd like to implement/see implemented
A file containing
//
or/*! .. */
based comments should also be spell checked.Describe alternatives you've considered
Status quo. Do not check them.
The text was updated successfully, but these errors were encountered: