Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make operations on dev comments opt-in #132

Closed
drahnr opened this issue Jan 4, 2021 · 0 comments · Fixed by #138
Closed

make operations on dev comments opt-in #132

drahnr opened this issue Jan 4, 2021 · 0 comments · Fixed by #138
Labels
bug Something isn't working good first issue 🔰 Good for newcomers help wanted 🤝 Extra attention is needed

Comments

@drahnr
Copy link
Owner

drahnr commented Jan 4, 2021

Describe the bug

Current master always includes developer comments.

To Reproduce

Use the default settings to reflow or check and observe
dev comments being operated on, which is a breaking change.

Expected behavior

Dev comments being checked optionally (cli flag and/or config option).

Ref #115
@drahnr drahnr added the bug Something isn't working label Jan 4, 2021
@drahnr drahnr assigned drahnr and unassigned drahnr Jan 4, 2021
@drahnr drahnr added good first issue 🔰 Good for newcomers help wanted 🤝 Extra attention is needed labels Jan 4, 2021
@drahnr drahnr mentioned this issue Jan 15, 2021
Merged
3 tasks
drahnr added a commit that referenced this issue Jan 16, 2021
@drahnr
allow dev comments to be enabled from cli, opt in (#138)
d430b36 
Closes #132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue 🔰 Good for newcomers help wanted 🤝 Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow dev comments to be enabled from cli, opt in drahnr/cargo-spellcheck
1 participant
@drahnr