New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add tests for BandAid and Suggestions, fix #18 #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's kinda shitty, but gives an overview how things work
|
It's confusing if the CI got stuck or not, since github only displays a linear checklist without any dependency implications.
Merged
closed in favor of #53 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR accomplish?
Bugfix: closes #18 .
Changes proposed by this PR:
Added unit tests for
BandAid
to find root cause of #18Notes to reviewer:
This is a very early draft. I just started adding some tests. I need more thorough understanding of the internals of
Suggestion
and the corresponding processing of from Strings/Literals intoBandAids
.Contributor Checklist
cargo test
cargo spellcheck
on the demo dir and verify output manuallycargo fix && cargo fmt
cargo spellcheck
on the source tree (optional)Reviewer Checklist