Bump mark to 9.11.1 #16
Conversation
| ENTRYPOINT ["/usr/bin/dumb-init", "--"] | ||
| CMD ["python3", "/app/mark2confluence/main.py"] |
There was a problem hiding this comment.
I don't think there is needs of an init script since the python script doesn't need to run as daemon here
There was a problem hiding this comment.
I think I agree about not changing the entrypoint
| WORKDIR /app | ||
| ENV PYTHONPATH /app | ||
| ENV DOC_PREFIX /github/workspace/ | ||
| ENV LOGURU_FORMAT "<lvl>{level:7} {message}</lvl>" | ||
| USER 1001:1001 |
There was a problem hiding this comment.
This is a quite big security concern, it will require an explicit exception to run it on our clusters. (Kyverno will prevent it to run at all, afaik)
There was a problem hiding this comment.
Agreed. How come we have to perform this change now? Did it work before with the unprivileged user?
The doc seems to go in the direction of that change though: https://docs.github.com/en/actions/creating-actions/dockerfile-support-for-github-actions#user
There was a problem hiding this comment.
no not really. I had to add this to my action to get it to work which is awful
- name: chown files to UID 1001
shell: bash
run: sudo chown -R 1001:1001 *
Dockerfile
Outdated
|
|
||
| FROM python:3-slim | ||
| FROM chromedp/headless-shell:latest |
There was a problem hiding this comment.
I'm not sure about this change instead of copy from builder...you are moving from 156MB of base image to more 285MB this will have a sensible impact on our build times
There was a problem hiding this comment.
Looks like this comment got marked as outdated. I agree with mbovo on this. No need to use a different/larger container.
|
There's been no progress for 3 weeks on this. Should I open a new PR with just upgrading the version of mark? |
USERinstruction in yourDockerfile, because you won’t be able to access theGITHUB_WORKSPACEdirectory.chromedp/headless-shell:latestimage instead.