Username and password fields on ULN Remotes should be hidden

closes pulp#2428
dralley · Mar 25, 2022 · b3d9279 · b3d9279
1 parent a0f517d
commit b3d9279
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/CHANGES/2428.bugfix b/CHANGES/2428.bugfix
@@ -0,0 +1 @@
+Fix ULN remote `username` and `password` fields which ought to have been write-only and hidden.
diff --git a/pulp_rpm/app/serializers/repository.py b/pulp_rpm/app/serializers/repository.py
@@ -170,11 +170,13 @@ class UlnRemoteSerializer(RpmBaseRemoteSerializer):
     username = serializers.CharField(
         help_text=_("Your ULN account username."),
         required=True,
+        write_only=True,
     )
-
     password = serializers.CharField(
         help_text=_("Your ULN account password."),
         required=True,
+        write_only=True,
+        style={"input_type": "password"},
     )
 
     url = serializers.CharField(