Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish py.typed to the right place #10

Merged
merged 1 commit into from May 23, 2022
Merged

publish py.typed to the right place #10

merged 1 commit into from May 23, 2022

Conversation

dimbleby
Copy link
Contributor

py.typed is supposed to live at the package root, currently users of this library are not seeing the types that it exposes.

MANIFEST.in Outdated Show resolved Hide resolved
Copy link
Owner

@dralshehri dralshehri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the develop base branch for pull request

@dimbleby dimbleby changed the base branch from main to develop May 23, 2022 16:12
@dimbleby
Copy link
Contributor Author

done

@dimbleby
Copy link
Contributor Author

workflow seems to be hitting psf/black#2964, looks like you'll want to update black

@dralshehri
Copy link
Owner

dralshehri commented May 23, 2022

Better to keep this pull request clean. I will ignore quality checks for now and merge you pull request.
Then I'll update requirements-dev.txt later.

@dimbleby
Copy link
Contributor Author

... so shall I remove the commit that updates black?

@dralshehri
Copy link
Owner

Yes please

@dralshehri dralshehri merged commit 74ff6bb into dralshehri:develop May 23, 2022
@dralshehri
Copy link
Owner

Thank you for your valuable contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants