Adding logs of disqualified nodes during DKG (#1058)

* Adding logs of disqualified nodes during DKG
* adding index to echoBroadcast reception logs

core/broadcast.go

@@ -135,7 +135,7 @@ func (b *echoBroadcast) BroadcastDKG(c context.Context, p *drand.DKGPacket) (*dr
 	}
 
 	b.l.Debugw("", "echoBroadcast",
-		"received new packet to echoBroadcast", "from", addr, "type", fmt.Sprintf("%T", dkgPacket))
+		"received new packet to echoBroadcast", "from", addr, "index", dkgPacket.Index(), "type", fmt.Sprintf("%T", dkgPacket))
 	b.sendout(hash, dkgPacket, false) // we're using the rate limiting
 	b.passToApplication(dkgPacket)
 	return new(drand.Empty), nil

core/drand_beacon.go

@@ -177,11 +177,18 @@ func (bp *BeaconProcess) WaitDKG() (*key.Group, error) {
 	// filter the nodes that are not present in the target group
 	var qualNodes []*key.Node
 	for _, node := range bp.dkgInfo.target.Nodes {
+		found := false
 		for _, qualNode := range res.Result.QUAL {
 			if qualNode.Index == node.Index {
 				qualNodes = append(qualNodes, node)
+				found = true
+				break
 			}
 		}
+
+		if !found {
+			bp.log.Debugw("disqualified node during DKG", "node", node)
+		}
 	}
 
 	s := key.Share(*res.Result.Key)

core/drand_beacon_control.go

@@ -937,7 +937,7 @@ func (bp *BeaconProcess) getPhaser(timeout uint32) *dkg.TimePhaser {
 	logger := bp.log
 	return dkg.NewTimePhaserFunc(func(phase dkg.Phase) {
 		bp.opts.clock.Sleep(tDuration)
-		logger.Debugw("", "phaser_finished", phase)
+		logger.Debugw("phaser timeout", "phaser_finished", phase)
 	})
 }
 

core/drand_beacon_public.go

@@ -21,10 +21,11 @@ func (bp *BeaconProcess) BroadcastDKG(c context.Context, in *drand.DKGPacket) (*
 	bp.state.Lock()
 	defer bp.state.Unlock()
 
+	addr := net.RemoteAddress(c)
+
 	if bp.dkgInfo == nil {
-		return nil, errors.New("drand: no dkg running")
+		return nil, fmt.Errorf("drand: no dkg running and yet received a DKGPacket for beacon %s from node %s", bp.beaconID, addr)
 	}
-	addr := net.RemoteAddress(c)
 
 	if !bp.dkgInfo.started {
 		bp.log.Infow("", "init_dkg", "START DKG",