Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme for new instructions to fetch package with go module #117

Closed
nikkolasg opened this issue May 6, 2019 · 2 comments
Closed

Update readme for new instructions to fetch package with go module #117

nikkolasg opened this issue May 6, 2019 · 2 comments

Comments

@nikkolasg
Copy link
Collaborator

Drand uses now go modules but the readme instructions are not updated. I think people should be using GO111MODULE=on go get ... otherwise we run into issues like #116 .
@AnomalRoil
Copy link
Member

Also we might want to check that the docker stuff is still working now with Go modules?

AnomalRoil added a commit that referenced this issue May 7, 2019
@AnomalRoil
Adding details about Go modules to Readme
1ca23fc 
Since we are now using Go modules, it seems there are a lot of details that need attention at setup.
This is trying to address them in the Readme.

Fixes #117
@AnomalRoil AnomalRoil mentioned this issue May 7, 2019
Closed
@nikkolasg
Copy link
Collaborator Author

drand now uses go modules by default, and with go1.14 i think it's by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updating Readme with Go modules drand/drand
2 participants
@nikkolasg @AnomalRoil