Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

db folder should be set after config folder is set #43

Closed
mahrud opened this issue Jul 1, 2018 · 3 comments
Closed

db folder should be set after config folder is set #43

mahrud opened this issue Jul 1, 2018 · 3 comments

Comments

@mahrud
Copy link

mahrud commented Jul 1, 2018

Even when --config is set, because of this line the db folder is created in the default config folder.
https://github.com/dedis/drand/blob/e268dedc327f443a07f2e77a1831aff407971423/main.go#L49
mahrud pushed a commit to mahrud/drand that referenced this issue Jul 1, 2018
drand#43: defines db folder after config folder is set
b3e2e14
@nikkolasg
Copy link
Collaborator

Cool, thanks, feel free to PR that change !

@mahrud
Copy link
Author

mahrud commented Jul 1, 2018

I'll test a few more things and add more commits if I find anything else, then make one PR.

@PizzaWhisperer
Copy link
Contributor

Fixed with #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nikkolasg @mahrud @PizzaWhisperer