Removing our weavework dep and upgrading grpc #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And passing remote metrics over grpc with protobuf now.
CluEleSsUK
reviewed
Jan 26, 2024
CluEleSsUK
reviewed
Jan 26, 2024
CluEleSsUK
reviewed
Jan 26, 2024
CluEleSsUK
reviewed
Jan 26, 2024
CluEleSsUK
reviewed
Jan 26, 2024
CluEleSsUK
reviewed
Jan 26, 2024
CluEleSsUK
reviewed
Jan 26, 2024
CluEleSsUK
reviewed
Jan 26, 2024
CluEleSsUK
reviewed
Jan 26, 2024
Also applying code review comments
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is also removing the TLS fields from our various structs, changing the way grpc connections work by first attempting a TLS one before falling back to a non-TLS one.
It also passes remote metrics over grpc with protobuf now instead of relying on weavework.
Sorry it's huge.