Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct docker readme with the latest commands #325

Merged
merged 3 commits into from
May 15, 2020
Merged

Correct docker readme with the latest commands #325

merged 3 commits into from
May 15, 2020

Conversation

nikkolasg
Copy link
Collaborator

No description provided.

@nikkolasg nikkolasg self-assigned this May 15, 2020
hsanjuan
hsanjuan approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@hsanjuan hsanjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Is the build process testing this (docker-compose up and checking the thing launched)? Otherwise it probably should.

@nikkolasg
Copy link
Collaborator Author

No it's not - I'm not sure what would be the best way to do it, creating an issue

@nikkolasg nikkolasg merged commit 8f249d8 into master May 15, 2020
@nikkolasg nikkolasg deleted the nikkolasg-patch-1 branch May 15, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsanjuan hsanjuan hsanjuan approved these changes

@willscott willscott Awaiting requested review from willscott

Assignees

@nikkolasg nikkolasg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nikkolasg @hsanjuan