Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

note dep update in release procedure #729

Merged
merged 3 commits into from
Aug 4, 2020
Merged

note dep update in release procedure #729

merged 3 commits into from
Aug 4, 2020

Conversation

willscott
Copy link
Member

No description provided.

Copy link
Contributor

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. Just some suggestions you may/may not want.

RELEASE.md Outdated Show resolved Hide resolved
@@ -5,6 +5,8 @@ This document describes the process for a public drand release.
## Major / Minor Releases

* A release is initiated by creating a protected release branch 'release-va.b' marking the major/minor release.
* Before beginning a release branch, check that dependencies have been pulled up to date:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be the first item? If there's any updates they need to be PR'd (and tested etc.).

RELEASE.md Outdated
@@ -5,6 +5,8 @@ This document describes the process for a public drand release.
## Major / Minor Releases

* A release is initiated by creating a protected release branch 'release-va.b' marking the major/minor release.
* Before beginning a release branch, check that dependencies have been pulled up to date:
```go list -u -m -mod=readonly -json all | go-mod-outdated -update -direct -style=markdown```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a note for installing go-mod-outdated?

willscott and others added 2 commits July 31, 2020 11:04
Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
@willscott willscott merged commit 39ef471 into master Aug 4, 2020
@willscott willscott deleted the deps branch August 4, 2020 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants