Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support environment proxies on outbound dials #737

Merged
merged 5 commits into from
Aug 8, 2020
Merged

support environment proxies on outbound dials #737

merged 5 commits into from
Aug 8, 2020

Conversation

willscott
Copy link
Member

@willscott willscott commented Aug 5, 2020 •
edited
Loading

When the ALL_PROXY environment variable is present, this uses the standard x/net/proxy implementation in go to proxy net dials made by GRPC.

e.g. the daemon would be run as ALL_PROXY=socks5://host:port drand start

@willscott willscott requested a review from alanshaw August 5, 2020 15:16
alanshaw
alanshaw reviewed Aug 7, 2020
View reviewed changes
net/client_grpc.go Outdated Show resolved Hide resolved
net/client_grpc.go Outdated Show resolved Hide resolved
@willscott willscott requested a review from alanshaw August 8, 2020 17:02
alanshaw
alanshaw approved these changes Aug 8, 2020
View reviewed changes
Copy link
Contributor

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@willscott willscott merged commit bdadb6f into master Aug 8, 2020
@willscott willscott deleted the proxy branch August 8, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanshaw alanshaw alanshaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@willscott @alanshaw