Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprioritize passive clients in optimizingclient.get #748

Merged
merged 3 commits into from
Sep 5, 2020
Merged

Deprioritize passive clients in optimizingclient.get #748

merged 3 commits into from
Sep 5, 2020

Conversation

willscott
Copy link
Member

  • when the libp2p client is marked 'passive' we should also not end up in cases where it is the first client to be queried when Get is called.
  • Changes error bubbling in the optimizing client to not only return the final sub-client error.

@willscott willscott merged commit 79c9572 into master Sep 5, 2020
@willscott willscott deleted the fix/deprioritizepassive branch September 5, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanshaw alanshaw alanshaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@willscott @alanshaw