Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document and test RoundToBytes #750

Merged
merged 2 commits into from
Sep 14, 2020

Conversation

webmaster128
Copy link
Contributor

See also drand/website#80

@webmaster128
Copy link
Contributor Author

By the way, is there a reason this is 2x duplicated in the client code?

func roundToBytes(r int) []byte {
	var buff bytes.Buffer
	binary.Write(&buff, binary.BigEndian, uint64(r))
	return buff.Bytes()
}

client/test/result/mock/result.go and test/mock/grpcserver.go?

@willscott
Copy link
Member

By the way, is there a reason this is 2x duplicated in the client code?

func roundToBytes(r int) []byte {
	var buff bytes.Buffer
	binary.Write(&buff, binary.BigEndian, uint64(r))
	return buff.Bytes()
}

client/test/result/mock/result.go and test/mock/grpcserver.go?

probably just a bad refactor

@nikkolasg nikkolasg merged commit 8c2ee78 into drand:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants