Expose own metrics in /metrics/peer/ #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rationaly here is that any metric scraper should support be configured in the same way regardless of the peer. By skipping a handler for the current peer we are creating an "exception" unique to every peer, which only makes things more difficult to maintain on infra-side of things. Also, chances are the index mapping is somehow borked, since in my tests it is sometimes skipping the current node and sometimes a different node, so this might fix that altogether.
willscott
approved these changes
Sep 28, 2020
hsanjuan
added a commit
that referenced
this pull request
Oct 2, 2020
Rationaly here is that any metric scraper should support be configured in the same way regardless of the peer. By skipping a handler for the current peer we are creating an "exception" unique to every peer, which only makes things more difficult to maintain on infra-side of things. Also, chances are the index mapping is somehow borked, since in my tests it is sometimes skipping the current node and sometimes a different node, so this might fix that altogether.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationaly here is that any metric scraper should support be configured in the
same way regardless of the peer. By skipping a handler for the current peer we
are creating an "exception" unique to every peer, which only makes things more
difficult to maintain on infra-side of things.
Also, chances are the index mapping is somehow borked, since in my tests it is
sometimes skipping the current node and sometimes a different node, so this might
fix that altogether.