more conservative channel behavior for waiters #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikkolasg
reviewed
Oct 2, 2020
| @@ -186,7 +186,8 @@ func (h *handler) getRand(ctx context.Context, info *chain.Info, round uint64) ( | |||
| h.pendingLk.RUnlock() | |||
| // If so, prepare, and if we're still sync'd, add ourselves to the list of waiters. | |||
| if block { | |||
| ch := make(chan []byte) | |||
| ch := make(chan []byte, 1) | |||
| defer close(ch) | |||
There was a problem hiding this comment.
Would it be possible to use the more safe Go pattern where the sender closes the channel, instead of the receiver ? so the receiver can simply for _ := range myChan { .. } safely.
There was a problem hiding this comment.
would you do it with a different channel for the receiver to notify the sender that its context has closed then?
nikkolasg
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was possible for a sequence to occur of:
This keeps the lock held by the watch loop during signalling.